Uses strings.Builder instead of []byte in iter.ReadString
#526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid allocations, also fixes tests still not working with go1.15. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
Whilst a string.Builder can reduce allocations it may actually be better to keep a small buffer or the builder around in order to reduce allocs further. |
Yes that sounds good. |
|
json-iterator already relies on unsafe reflect2 package. Than why no simply cast byte slice to string using unsafe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid allocations, also fixes tests still not working with go1.15.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com