-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Iterator.Buffered() method to mimic json.Decoder #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We���ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize string processing
Added parse benchmarks
Backport fixes from upstream
Added Stream.WriteTime
plus do some API cleanups
Replace ReadStringAsSlice with ReadRawString
Faster rawstring
add ReadStringAsSlice compatibility with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
Buffered()
method to the Iterator that mimics the behavior of Go's standard libraryjson.Decoder.Buffered()
.Changes
✨ New Feature: Iterator.Buffered() method
Iterator.Buffered() io.Reader
- Returns a reader of the data remaining in the Iterator's bufferjson.Decoder.Buffered()
from Go's standard library🐛 Bug Fixes: Error Position Reporting
Fixed multiple instances of missing
iter.unreadByte()
calls, which allow using the Buffered more effectively.These fixes ensure that when parsing errors occur, the iterator can return buffer including the problematic character rather than the character after it.
Use Cases
The
Buffered()
method enables:Testing