Skip to content

Disable BuildKit's InvalidDefaultArgInFrom build check#6409

Merged
jnummelin merged 1 commit intok0sproject:mainfrom
twz123:silence-docker-warning
Oct 22, 2025
Merged

Disable BuildKit's InvalidDefaultArgInFrom build check#6409
jnummelin merged 1 commit intok0sproject:mainfrom
twz123:silence-docker-warning

Conversation

@twz123
Copy link
Copy Markdown
Member

@twz123 twz123 commented Sep 17, 2025

Description

The BUILDIMAGE argument has no default value by design, since it always comes from the Makefile. So disable the check.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
@twz123
Disable BuildKit's InvalidDefaultArgInFrom build check
8fefe32 
The BUILDIMAGE argument has no default value by design, since it always
comes from the Makefile. So disable the check.

See: e42ca53 ("Disable BuildKit's InvalidDefaultArgInFrom build check")
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added the chore label Sep 17, 2025
@twz123 twz123 marked this pull request as ready for review September 17, 2025 10:06
@twz123 twz123 requested review from a team as code owners September 17, 2025 10:06
@twz123 twz123 requested review from makhov and ncopa September 17, 2025 10:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 17, 2025

The PR is marked as stale since no activity has been recorded in 30 days
@github-actions github-actions Bot added Stale and removed Stale labels Oct 17, 2025
@jnummelin jnummelin merged commit fca46c8 into k0sproject:main Oct 22, 2025
184 of 186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore

2 participants

@twz123 @jnummelin