Skip to content

Replace rqlite with modernc.org/sqlite#6515

Merged
twz123 merged 3 commits intok0sproject:mainfrom
s3rj1k:modernc.org/sqlite
Nov 14, 2025
Merged

Replace rqlite with modernc.org/sqlite#6515
twz123 merged 3 commits intok0sproject:mainfrom
s3rj1k:modernc.org/sqlite

Conversation

@s3rj1k
Copy link
Copy Markdown
Contributor

@s3rj1k s3rj1k commented Oct 14, 2025

Description

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
@s3rj1k s3rj1k requested review from a team as code owners October 14, 2025 00:06
@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch 2 times, most recently from 735d1ff to bcb7ef7 Compare October 14, 2025 08:29
@twz123 twz123 linked an issue Oct 14, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Has been in the backlog since forever ^^

Comment thread Makefile Outdated
Comment thread pkg/backup/sqlitedb_unix.go Outdated
@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch from bcb7ef7 to 4aeb03b Compare October 14, 2025 09:48
Comment thread pkg/backup/sqlitedb_unix.go Outdated
@twz123
Copy link
Copy Markdown
Member

twz123 commented Nov 5, 2025

@s3rj1k #6568 has been merged. Would you be able to rebase this and address the few nits?

@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch from 4aeb03b to 606034b Compare November 5, 2025 09:02
@s3rj1k
Copy link
Copy Markdown
Contributor Author

s3rj1k commented Nov 5, 2025

@s3rj1k #6568 has been merged. Would you be able to rebase this and address the few nits?

Done, except that VACUUM change, lets test that a bit later

@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch from a0008cd to 69840d3 Compare November 7, 2025 10:21
s3rj1k and others added 2 commits November 14, 2025 11:03
Signed-off-by: s3rj1k <evasive.gyron@gmail.com>
Co-authored-by: Tom Wieczorek <twz123@users.noreply.github.com>
Signed-off-by: Serhii Ivanov <11349489+s3rj1k@users.noreply.github.com>
@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch from babddd3 to 86f374c Compare November 14, 2025 10:04
Co-authored-by: Tom Wieczorek <twz123@users.noreply.github.com>
Signed-off-by: Serhii Ivanov <11349489+s3rj1k@users.noreply.github.com>
@twz123 twz123 merged commit 2df25c4 into k0sproject:main Nov 14, 2025
200 of 201 checks passed
@s3rj1k s3rj1k deleted the modernc.org/sqlite branch November 14, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants