Skip to content

Add --feature-gates flag to the k0s config subcommand#6613

Merged
twz123 merged 1 commit intok0sproject:mainfrom
twz123:fix-config-valiate
Nov 7, 2025
Merged

Add --feature-gates flag to the k0s config subcommand#6613
twz123 merged 1 commit intok0sproject:mainfrom
twz123:fix-config-valiate

Conversation

@twz123
Copy link
Copy Markdown
Member

@twz123 twz123 commented Nov 7, 2025

Description

This prevents a panic when validating an IPv6-only k0s config.

NB: CallPersistentPreRun has been resurrected from commit f977380.

Fixes:

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
@twz123 twz123 added bug Something isn't working area/configuration area/cli backport/release-1.34 PR that needs to be backported/cherrypicked to the release-1.34 branch labels Nov 7, 2025
@twz123 twz123 force-pushed the fix-config-valiate branch 3 times, most recently from 974f4b0 to 1c35f22 Compare November 7, 2025 10:30
This prevents a panic when validating an IPv6-only k0s config.

NB: CallPersistentPreRun has been resurrected from commit f977380.

Fixes: a50271d ("Implement k0s feature gates")
See: f977380 ("Encapsulate debug flag handling")
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 force-pushed the fix-config-valiate branch from 1c35f22 to 5fe0612 Compare November 7, 2025 10:35
@twz123 twz123 marked this pull request as ready for review November 7, 2025 12:48
@twz123 twz123 requested review from a team as code owners November 7, 2025 12:48
@twz123 twz123 requested review from kke and ncopa November 7, 2025 12:48
@twz123 twz123 merged commit 02573e5 into k0sproject:main Nov 7, 2025
200 of 201 checks passed
@twz123 twz123 deleted the fix-config-valiate branch November 7, 2025 12:53
@k0s-bot
Copy link
Copy Markdown
Contributor

k0s-bot commented Nov 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli area/configuration backport/release-1.34 PR that needs to be backported/cherrypicked to the release-1.34 branch bug Something isn't working

3 participants