Skip to content

Fix go mod directive renovate updates#6624

Merged
twz123 merged 1 commit intok0sproject:mainfrom
twz123:renovate-bump-go-directive
Nov 10, 2025
Merged

Fix go mod directive renovate updates#6624
twz123 merged 1 commit intok0sproject:mainfrom
twz123:renovate-bump-go-directive

Conversation

@twz123
Copy link
Copy Markdown
Member

@twz123 twz123 commented Nov 7, 2025

Description

The previous configuration assumed that the go.mod files in k0s would always remain at the .0 patch level. However, if a dependency declares a higher patch level for any reason, k0s must follow that.

Fixing this requires rewriting the go directive from "go 1.xx.y" to "go 1.zz.0". Additionally, the regular expression was broken. Apparently, it's not a good idea to use line beginning and line end markers for Renovate regular expressions. Replace those with the word boundary marker.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
The previous configuration assumed that the go.mod files in k0s would
always remain at the .0 patch level. However, if a dependency declares a
higher patch level for any reason, k0s must follow that.

Fixing this requires rewriting the go directive from "go 1.xx.y" to "go
1.zz.0". Additionally, the regular expression was broken. Apparently,
it's not a good idea to use line beginning and line end markers for
Renovate regular expressions. Replace those with the word boundary
marker.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added bug Something isn't working area/ci labels Nov 7, 2025
@twz123 twz123 marked this pull request as ready for review November 7, 2025 17:00
@twz123 twz123 requested review from a team as code owners November 7, 2025 17:00
@twz123 twz123 requested review from jnummelin and ncopa November 7, 2025 17:00
@twz123 twz123 enabled auto-merge November 7, 2025 17:06
@twz123 twz123 merged commit 453995a into k0sproject:main Nov 10, 2025
6 checks passed
@twz123 twz123 deleted the renovate-bump-go-directive branch November 10, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci bug Something isn't working

2 participants