Skip to content

Add honorLabels to pushgateway ServiceMonitor example in the Docs#6654

Merged
twz123 merged 1 commit intok0sproject:mainfrom
hille721:patch-1
Nov 13, 2025
Merged

Add honorLabels to pushgateway ServiceMonitor example in the Docs#6654
twz123 merged 1 commit intok0sproject:mainfrom
hille721:patch-1

Conversation

@hille721
Copy link
Copy Markdown
Contributor

Description

Without honorLabels: true the labels of the scraped metrics from the Pushgateway will have a exported_ prefix.

With that the query in the docs (absent(apiserver_audit_event_total{job="kube-scheduler"})) would still not work as it would be absent(apiserver_audit_event_total{exported_job="kube-scheduler"}).

With honorLabels: true, everything works as expected and also other queries are working in the same way as they are on other distributions without isolated CP.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added
currently the labels will have a `exported_prefix`

Signed-off-by: Christoph Hille <38468371+hille721@users.noreply.github.com>
@hille721 hille721 requested review from a team as code owners November 13, 2025 08:54
@twz123 twz123 added documentation Improvements or additions to documentation backport/release-1.34 PR that needs to be backported/cherrypicked to the release-1.34 branch labels Nov 13, 2025
Copy link
Copy Markdown
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@twz123 twz123 merged commit 6b0f8d0 into k0sproject:main Nov 13, 2025
9 checks passed
@k0s-bot
Copy link
Copy Markdown
Contributor

k0s-bot commented Nov 13, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/release-1.34 PR that needs to be backported/cherrypicked to the release-1.34 branch documentation Improvements or additions to documentation

3 participants