[Backport release-1.34] Use filepath.Join for local filesystem paths#7313
Merged
twz123 merged 1 commit intok0sproject:release-1.34from Mar 19, 2026
Merged
Conversation
Most (all?) of these code paths are not used in production on Windows, but they represent local file system paths and should use filepath.Join() rather than path.Join(). Leave path.Join() alone when operating on anything other than local file system paths. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit 9971cd2) (cherry picked from commit 1695d3e)
twz123
added
chore
backport/release-1.33
jnummelin
approved these changes
Mar 19, 2026
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to
release-1.34:See: