#434 – Update validation logic for cropty.py - #436
Merged
kaifcodec merged 2 commits intoJul 24, 2026
Merged
Conversation
A-S-Manoj
reviewed
Jul 23, 2026
A-S-Manoj
left a comment
A-S-Manoj
left a comment
Contributor
There was a problem hiding this comment.
LGTM, logic is correct, traced the reported payload through and it resolves properly. I haven't tested against the live API myself, so hoping the author has verified it locally. Left one inline comment on an unrelated pre-existing fallthrough worth tightening before merge.
Co-authored-by: A Sivasubramanian Manoj <sivasubramanianmanoj2310533@ssn.edu.in>
json-hunter07
approved these changes
Jul 24, 2026
Owner
|
@SpiliosDimakopoulos Thank you for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…opty.py (closes #434)