fix: reject usernames causing false positives in Calendly, IFTTT, OpenStreetMap modules - #437
Merged
kaifcodec merged 2 commits intoJul 24, 2026
Conversation
…nStreetMap modules
Owner
|
@kristoisberg I will review it after some hours, thank you for the PR. |
kaifcodec
requested changes
Jul 24, 2026
kaifcodec
previously approved these changes
Jul 24, 2026
kaifcodec
left a comment
kaifcodec
left a comment
Owner
There was a problem hiding this comment.
@kristoisberg Thank you for catching this!
Great work on this. If you stay consistent and have dedicated time for the project, we would definitely be open to bringing you on as a maintainer down the line, specifically to help manage error handling, site updates, and resolving false positives or negatives alongside the team. Keep it up!
kaifcodec
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rejects usernames containing periods in Calendly, IFTTT, and OpenStreetMap, which were causing false positives as websites were only checking the part of username before the period. A good test case is the username "test.ddfdddgfdgf".