Fix: replace silent Result.taken() fallthrough with explicit Result.error() - #450
Merged
Merged
Conversation
…rror() across 7 modules (closes kaifcodec#449)
kaifcodec
approved these changes
Jul 24, 2026
kaifcodec
left a comment
kaifcodec
left a comment
Owner
There was a problem hiding this comment.
@A-S-Manoj Thanks for the PR, it is ok to me. Merging it.
kaifcodec
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #449
Summary
Several
user_scanvalidators silently swallowed parse failures or unrecognized200response shapes and fell through to an unconditionalResult.taken(), instead of returningResult.error(...)as required by the module guidelines (Strict Error Handling section of CONTRIBUTING.md).This replaces that fallback with an explicit error across all 7 affected files:
Files changed
user_scanner/user_scan/finance/destream.pyuser_scanner/user_scan/gaming/apexlegends.pyuser_scanner/user_scan/gaming/minecraft.pyuser_scanner/user_scan/gaming/lichess.pyuser_scanner/user_scan/gaming/chess_com.pyuser_scanner/user_scan/dev/codecademy.pyuser_scanner/user_scan/dev/githubgist.pyTesting
ruff check .— passedmypy user_scanner— passedpytest— no test regressions (no per-module tests exist for these validators; existing suite unaffected)