Skip to content

fix: mastodon email module false positives - #466

Merged
kaifcodec merged 1 commit into
kaifcodec:mainfrom
kristoisberg:feature/mastodon-email-false-positives
Jul 26, 2026
Merged

fix: mastodon email module false positives#466
kaifcodec merged 1 commit into
kaifcodec:mainfrom
kristoisberg:feature/mastodon-email-false-positives

Conversation

@kristoisberg

Copy link
Copy Markdown
Collaborator

This PR tightens error message checks in the Mastodon email module, which was producing a false positive for every email. The previous "has already been taken" check also matched the error message for the username field. I have a suspicion that the user was actually registered by user-scanner since the module is probing the registration endpoint, in which case the module was "loud" for exactly one run.

@kaifcodec kaifcodec left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kristoisberg Solid catch!
Need to merge it soon, and bump the version.

@kaifcodec
kaifcodec merged commit 2faaf14 into kaifcodec:main Jul 26, 2026
2 checks passed
@kristoisberg

Copy link
Copy Markdown
Collaborator Author

@kristoisberg Solid catch! Need to merge it soon, and bump the version.

There are a few similar issues left, which I'm fixing today, if you wish to wait for them before bumping the version. They're not as consistently annoying as the Mastodon ones and only affect less-known email providers on certain sites.

@kaifcodec

Copy link
Copy Markdown
Owner

@kristoisberg No need to worry, you work on those.
I am planning to bump the version soon because a false positive is the worst error that we can have (even the false negative is better than it).
We will bump again after those fixes.

@kaifcodec kaifcodec added enhancement New feature, request, code improvements/upgrade, performance boost bug fix Fixed a bug in existing files labels Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix Fixed a bug in existing files enhancement New feature, request, code improvements/upgrade, performance boost

2 participants