fix: mastodon email module false positives - #466
Merged
kaifcodec merged 1 commit intoJul 26, 2026
Merged
Conversation
kaifcodec
approved these changes
Jul 26, 2026
kaifcodec
left a comment
Owner
There was a problem hiding this comment.
@kristoisberg Solid catch!
Need to merge it soon, and bump the version.
Collaborator
Author
There are a few similar issues left, which I'm fixing today, if you wish to wait for them before bumping the version. They're not as consistently annoying as the Mastodon ones and only affect less-known email providers on certain sites. |
Owner
|
@kristoisberg No need to worry, you work on those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens error message checks in the Mastodon email module, which was producing a false positive for every email. The previous "has already been taken" check also matched the error message for the username field. I have a suspicion that the user was actually registered by user-scanner since the module is probing the registration endpoint, in which case the module was "loud" for exactly one run.