docs: explain browser impersonation helpers - #472
Merged
Conversation
brunolm
reviewed
Jul 29, 2026
brunolm
left a comment
Collaborator
There was a problem hiding this comment.
- Document
allow_redirects(defaultFalse) and the httpx name difference (follow_redirectsvsallow_redirects).
- `allow_redirects` defaults to `False` (curl_cffi). This is the opposite of httpx’s `follow_redirects=True` used with `generic_validate`; pass `allow_redirects=True` when the profile URL redirects. Extra kwargs are forwarded to `impersonate_request`.
- Example taken check is too weak (user in response.text); align with CRITICAL rule 1.
def process(response):
if response.status_code == 404 and "User does not exist" in response.text:
return Result.available()
if response.status_code == 200 and f'profile/{user}' in response.text:
# Prefer a unique body marker (title, canonical, embedded user id) —
# not a bare `user in response.text` check (boilerplate false positives).
return Result.taken()
return Result.error(f"Unexpected response status: {response.status_code}")
Contributor
Author
|
Thanks — addressed both documentation points in
Fresh validation: focused documentation assertions and |
brunolm
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
impersonate_validateinstead ofgeneric_validatewarmup_url,impersonate, andshow_urlimpersonate_requestis useful for multi-step flowsValidation
git diff --checkThe full test and lint suites were not run locally because the dependency environment could not be installed within the available disk quota; I deferred them to CI because this change only updates documentation.
Fixes #464