fix: Bluesky username module false positives - #488
Merged
kaifcodec merged 2 commits intoAug 2, 2026
Conversation
kaifcodec
approved these changes
Aug 2, 2026
kaifcodec
left a comment
kaifcodec
left a comment
Owner
There was a problem hiding this comment.
@kristoisberg I just refactored the error message as this one tells the user to report it.
kaifcodec
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes false positives in the Bluesky username module. In addition to taken usernames, the currently used "checkHandleAvailability" RPC call also rejects usernames that are invalid for other reasons.
I removed the "checkHandleAvailability" RPC call, instead checking username availability using the "getProfile" RPC, which was already used to fetch enrichments. As a result, the module also became much simpler.
Previously false positive test case:
user-scanner -u dgfghhfghfgfghijogh --verbose -m bluesky