Skip to content

Render generic identifiers as text inputs - #28

Open
masnwilliams wants to merge 1 commit into
mainfrom
hypeship/render-identifiers-as-text
Open

Render generic identifiers as text inputs#28
masnwilliams wants to merge 1 commit into
mainfrom
hypeship/render-identifiers-as-text

Conversation

@masnwilliams

@masnwilliams masnwilliams commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

summary

  • render canonical identifier fields as text inputs regardless of their credential ref
  • preserve combined username, email, and phone labels without browser-native email or telephone validation
  • add regression coverage for email-, username-, and phone-named canonical identifiers

testing

  • bun test
  • bun run build
  • bun run typecheck
  • bun run format:check

release

Includes a patch changeset for @onkernel/managed-auth-react.


Note

Low Risk
Localized form rendering change in managed auth UI with no auth or data-handling impact; main effect is dropping strict browser validation on identifier inputs.

Overview
Canonical identifier fields now always map to plain text inputs in @onkernel/managed-auth-react, instead of inferring email or tel from the field ref (e.g. email, phone_number). Username/email/phone labels stay the same, but the browser no longer applies native email or telephone validation on those steps.

Regression tests cover identifier refs named like email, username, and phone. A patch changeset is included for the package release.

Reviewed by Cursor Bugbot for commit 2280ac3. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
managed-auth-react-demo Ready Ready Preview Aug 30, 2026 11:08pm
@masnwilliams
masnwilliams requested review from akxue and dcruzeneil2 and removed request for dcruzeneil2 August 31, 2026 20:38

@akxue akxue left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed — looks good, straightforward fix

  • packages/managed-auth-react/src/session/state.ts:44 — always-text for identifiers is the right default; the ref-sniffing was fragile (substring false positives) and native email/tel validation breaks combined fields. tradeoff noted: pure email/phone fields lose inputmode hints on mobile — worth revisiting smarter inference (ideally server-provided) once there's more signal
  • test coverage pins both removed inference branches (email-ref and phone-ref), and the fixture label reflects the real combined-field case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants