Update cors.js #4650
Open
Update cors.js #4650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Access-Control-Allow-Credentials header to cors middleware keystonejs#4380 https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#Access-Control-Allow-Credentials The only valid value for this header is true, so I've not added in a "keystone.get('cors allow credentials')" bit like in the 'methods' and 'headers' settings. Hopefully that seems ok!
dominikwilkowski
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added another cors header setting, following the pattern of the others in this file.
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#Access-Control-Allow-Credentials
The only valid value for this header is true, so I've not added in a "keystone.get('cors allow credentials')" bit like in the 'methods' and 'headers' settings.
Hopefully that seems ok!
Related issues (if any)
Add Access-Control-Allow-Credentials header to cors middleware #4380
Testing
npm run test-allran successfully.