Fix Admin UI remaining editable when graphql.omit.update is set - #10007
Open
FirmaSpring wants to merge 2 commits into
Open
Fix Admin UI remaining editable when graphql.omit.update is set#10007FirmaSpring wants to merge 2 commits into
FirmaSpring wants to merge 2 commits into
Conversation
Force itemView.fieldMode to read when update is omitted from GraphQL, even if ui.itemView.fieldMode is configured as edit. Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
FirmaSpring
force-pushed
the
fix/omit-update-itemview
branch
from
August 17, 2026 07:50
17dd953 to
955916a
Compare
emmatown
reviewed
Aug 17, 2026
emmatown
left a comment
emmatown
left a comment
Member
There was a problem hiding this comment.
This would break a dynamic fieldMode changing between read and hidden
Only coerce a static edit mode to read. Functions and filter objects that switch between read and hidden stay intact. Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
Contributor
Author
|
Thanks @emmatown. The previous change collapsed any non-hidden fieldMode to a static I updated this so
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
graphql.omit.updateis set on a field, the Admin UI item view can still be editable.packages/core/src/lib/core/initialise-lists.tscurrently prefers the configuredui.itemView.fieldModeeven after update is omitted. If a developer (or a leftover default) setsfieldMode: 'edit', the field is shown as editable even though GraphQL has no update input for it. This is the remaining case of #9665 after #9663/#9664.Solution
If
graphql.omit.updateis true and the field is still readable, forceitemView.fieldModeto'read'. An expliciteditconfiguration cannot override the omitted update operation.Verification
Added
graphql.omit.update forces itemView.fieldMode to read even if edit is configuredintests/api-tests/admin-meta.test.ts.Fixes #9665