fix(langgraph): skip RESUME writes in _prepare_state_snapshot so get_state().next is correct after double interrupt#6958
Open
GAUTAM V DATLA (gautamvarmadatla) wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
…t is correct after double interrupt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_prepare_state_snapshotand_aprepare_state_snapshotskipped ERROR and INTERRUPT writes when replaying pending_writes into task.writes, but did not skip RESUME writes.When a node calls
interrupt()twice, commit() persists both (task_id, INTERRUPT, ...) and (task_id, RESUME, ...) to pending_writes. On the nextget_state()call, the RESUME write was incorrectly replayed into task.writes, making the write list non-empty and excluding the task fromStateSnapshot.next. This made the graph appear finished even though it was still paused waiting for user input.Fixed by adding RESUME to the skip condition in both sync and async paths, consistent with _match_writes which already skipped RESUME correctly.
fixes: #6956