fix(checkpoint): don't silently return None when deserialization fails#6975
Open
Zephyr Cao (A404coder) wants to merge 1 commit intolangchain-ai:mainfrom
Open
fix(checkpoint): don't silently return None when deserialization fails#6975Zephyr Cao (A404coder) wants to merge 1 commit intolangchain-ai:mainfrom
Zephyr Cao (A404coder) wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
Fixes langchain-ai#6970 - JsonPlusSerializer was silently replacing values with None when msgpack deserialization failed for allowed modules. Changes: - Remove try/except blocks that swallowed exceptions in ext_hook - Keep allowed module check but let deserialization errors propagate - This prevents silent data loss when modules are deleted or changed Now when a module is allowed but deserialization fails, an exception is raised instead of returning None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6970 - JsonPlusSerializer was silently replacing values with None when msgpack deserialization failed.
Problem
When a module is in the allowed list but deserialization fails (e.g., module was deleted), the serializer silently returns None instead of raising an error. This causes silent data loss in checkpoints.
Solution
Remove the try/except blocks that swallowed exceptions in ext_hook. The allowed module check still returns the serialized data for disallowed modules, but allowed modules that fail deserialization now raise exceptions.
Changes
Fixes #6970