fix(cli): normalize auth and encryption paths to POSIX format#6983
Open
Br1an (Br1an67) wants to merge 1 commit intolangchain-ai:mainfrom
Open
fix(cli): normalize auth and encryption paths to POSIX format#6983Br1an (Br1an67) wants to merge 1 commit intolangchain-ai:mainfrom
Br1an (Br1an67) wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
Use .as_posix() on relative path segments in _update_auth_path and _update_encryption_path, matching the existing pattern in _update_graphs_paths. On Windows, pathlib produces backslashes in relative_to() results, which get written into Dockerfile ENV values causing invalid container paths. Fixes langchain-ai#5815
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Normalize Windows paths to POSIX format in
_update_auth_pathand_update_encryption_pathby calling.as_posix()onrelative_to()results. This matches the existing pattern used in_update_graphs_paths(line 576, 583) wherecontainer_path.as_posix()andcontainer_subpath.as_posix()are already called. Without this, on Windows theLANGGRAPH_AUTHENV in the generated Dockerfile contains backslash path separators (e.g.flowee\\security\\auth.py) instead of forward slashes.Issue: Fixes #5815
Dependencies: None