Conversation
ryannedolan
approved these changes
Jan 21, 2026
Collaborator
ryannedolan
left a comment
There was a problem hiding this comment.
Interesting. We should consider rewriting JdbcSchema to better suit our purposes.
Collaborator
Author
Yep I agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue is hopefully explained well in comments.
The issue stems from Calcite JdbcSchema, snippet pasted below
We on the other hand were generating the type as
INTEGER ARRAY NOT NULLwhich conflicts with theendsWith(resulting in the type being passed through JDBC asANY ARRAYAdded tests to cover this.