chore: remove dead _ToolOutput, _JsOutput, _SanitizedOutput classes

[detail-app]

Description

Removes the unused _ToolOutput, _JsOutput (and its sanitize()/create() methods), and _SanitizedOutput classes from agents/src/voice/generation.ts.

Changes Made

• Removed _ToolOutput (~9 lines) — deprecated in favor of ToolOutput
• Removed _SanitizedOutput (~28 lines) — its only consumer was _JsOutput.sanitize()
• Removed _JsOutput class including sanitize() and static create() (~83 lines) — deprecated in favor of ToolExecutionOutput/createToolOutput

Context

These three classes formed a self-contained cluster with zero production call-sites (and zero test references) anywhere in agents/ or plugins/. Their sole former consumer (performToolExecutions) was migrated to the new ToolOutput/ToolExecutionOutput/createToolOutput API over a year ago in PR #549, at which point the author (Brian Yin) added explicit // TODO(brian): remove this class in favor of ... annotations above each one — not as aspirational future-use notes, but bound to the same migration commit. The API replacement (createToolOutput) preserves the same sanitization behavior (including isValidToolOutput validation, which remains used by the live createToolOutput and was retained). None of the three classes are re-exported from the public package API.

History

• Last materially changed July 2025 (brianyin/ajs-107-chatcontext-to_dict-for-observability #531 @toubatbrian)

Pre-Review Checklist

• Build passes: All builds (lint, typecheck, tests) pass locally
• AI-generated code reviewed: Removed unnecessary comments and ensured code quality
• Changes explained: All changes are properly documented and justified above
• Scope appropriate: All changes relate to the PR title

Testing

• All tests pass (pnpm vitest run on generation/agent_activity/tool_output_commit/running_tool_placeholders suites — 97 tests)
• pnpm build in agents/ succeeds

Additional Notes

The three // TODO(brian): remove ... comments are removed along with the classes. No imports became unused as a result (isToolError, isStopResponse, isAgentHandoff, isValidToolOutput are all still consumed by the live createToolOutput).

---

Dead Code PRs can be configured here.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6d32f61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.