fix(tokenize): strip backslash and all declared punctuation from words - #2385
Open
rohitsux wants to merge 1 commit into
Open
fix(tokenize): strip backslash and all declared punctuation from words#2385rohitsux wants to merge 1 commit into
rohitsux wants to merge 1 commit into
Conversation
splitWords built its filter by joining PUNCTUATIONS into a regex character class. Because the list contains both `\` and `]`, the joined class held the fragment `[\]`, where `\]` is an escaped literal `]` — so the backslash was consumed as an escape and never a class member, and was never stripped when ignorePunctuation is on. Strip by Set membership instead, removing exactly the declared characters and eliminating the escaping/range fragility.
🦋 Changeset detectedLatest commit: b579a6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![devin-ai-integration[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
splitWords(the basic word tokenizer's punctuation stripper) builds its filter by concatenatingPUNCTUATIONSinto a regex character class:new RegExp([${PUNCTUATIONS.join('')}], 'g'). Because the list contains both\and], the joined class contains the fragment[\], where\]is parsed as an escaped literal]— so the backslash is consumed as an escape and is never a class member. Backslash (a declared punctuation) is therefore never stripped whenignorePunctuationis on (the default). The adjacent,-.also silently forms a character range.Fix
Strip by
Setmembership instead of a regex built from data — removes exactly the declared characters (backslash included) and eliminates the escaping/range fragility.splitWords' signature and behavior are otherwise unchanged.Test
Adds a regression test in
tokenizer.test.ts:splitWords('c\\d', true)now yields[['cd', 0, 3]](was[['c\\d', 0, 3]]), and confirmsignorePunctuation: falsestill preserves it. Full tokenizer suite green; typecheck, lint, and prettier clean.