fix(agents): evict dead warmed processes - #2388
Open
kokoite wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 87f4d75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2321.
ProcPooltransferred ownership of a warmed process'sMultiMutexunlock token towarmedProcQueue, but the watcher only removed the executor fromexecutorswhen that idle process exited. The stale queue entry could therefore be dequeued for a later job, and its capacity slot remained occupied until then.Changes Made
procWatchTaskand remove it by object identity if the process exits before a consumer claims it.close()and the watcher cannot release the same slot twice.Pre-Review Checklist
Testing
pnpm test agents/src/ipc/proc_pool.test.ts— 8 passedpnpm test agents --silent— 2,322 passed, 5 skippedpnpm build:agentspnpm typecheckpnpm lintpnpm format:checkpnpm throws:checkrestaurant_agent.tsandrealtime_agent.tsmanual checks are not applicable to this internal process lifecycle fixAdditional Notes
The ownership rule is based on synchronous queue removal:
launchJob(), watcher cleanup, andclose()each release a token only after successfully claiming its queue entry. This keeps every warmed-process capacity slot paired with exactly one release path.Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.