fix(google): don't let closing the TTS input generator mask the real error - #7041
Open
avionicharshit-byte wants to merge 1 commit into
Open
Conversation
|
|
avionicharshit-byte
marked this pull request as ready for review
August 29, 2026 18:13
![devin-ai-integration[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SynthesizeStream._run_streamhandsinput_gento the grpc client, which drives it from its own task. when the call fails, that task is usually still parked inside the generator waiting for the next sentence, so theawait input_gen.aclose()in thefinallyraisesand that replaces the
APITimeoutError/APIStatusErrorthe caller was meant to see. it shows up on interrupted turns and on deadline exceeded, so it reads as intermittent.same race and same fix as #4766, which guarded the
aclose()calls inutils/aio/itertools.py.added
tests/test_plugin_google_tts_stream_close.py: a fake client consumesinput_genfrom a background task, then raisesDeadlineExceeded. it fails on main with the RuntimeError and passes with the guard.