Ensure malformed decode events log and continue processing#214
Merged
donoghuc merged 3 commits intologstash-plugins:mainfrom Jan 21, 2026
Merged
Ensure malformed decode events log and continue processing#214donoghuc merged 3 commits intologstash-plugins:mainfrom
donoghuc merged 3 commits intologstash-plugins:mainfrom
Conversation
This commit fixes a bug whereby on error a Logger object was returned resulting in a NoMethodError when attempting to iterate over a result. The fix involves moving error handling such that errors are logged and processing continues (rather than stopping and letting a NoMethodError propogate).
mashhurs
approved these changes
Jan 21, 2026
mashhurs
left a comment
mashhurs
left a comment
There was a problem hiding this comment.
I agree with the return type, so changes LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug whereby on error a Logger object was returned resulting in a NoMethodError when attempting to iterate over a result. The fix involves moving error handling such that errors are logged and processing continues (rather than stopping and letting a NoMethodError propogate).
TODO: Once we agree on direction add release prep (changelog, version bumps, etc).