Merged
Conversation
mashhurs
commented
Jan 28, 2026
lib/jruby-dissect-library_jars.rb
Outdated
|
|
||
| require 'jar_dependencies' | ||
| require_jar('org.logstash.dissect', 'jruby-dissect-library', '1.2.1') | ||
| require_jar('org.logstash.dissect', 'jruby-dissect-library', '1.2.5') |
Contributor
Author
There was a problem hiding this comment.
Somehow this is holding old version 🤔
There was a problem hiding this comment.
Yeah, this file should not be tracked in git IMO. It is generated a publish time and will bound to be wrong/inaccurate over time.
| s.email = 'info@elastic.co' | ||
| s.homepage = "http://www.elastic.co/guide/en/logstash/current/index.html" | ||
| s.require_paths = ["lib", "vendor/jars"] | ||
| s.require_paths = ["lib", "vendor/jar-dependencies"] |
Contributor
Author
There was a problem hiding this comment.
standardized as other plugins...
donoghuc
reviewed
Jan 29, 2026
| task generateGemJarRequiresFile { | ||
| doLast { | ||
| File jars_file = file("lib/${project.name}_jars.rb") | ||
| File jars_file = file("lib/jruby-dissect-library_jars.rb") |
There was a problem hiding this comment.
Probably not worth changing this to the plugin name...
Contributor
Author
There was a problem hiding this comment.
Yeah, it requires not purely logic but logic file (
) change. Leaving it as it focusing only on re-packaging.
donoghuc
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs: