Merged
Conversation
Contributor
Author
|
I have bit-by-bit compared this change (especially Failed CI step ( |
* ESQL and DSL executors are introduced. param can accept ES|QL query shape now. is introduced for initial step but needs team's feedback. DSL logics moved into DSL executors. * Apply suggestions from code review Separate DSL and ESQL interface in the client. Co-authored-by: Rye Biesemeyer <yaauie@users.noreply.github.com> * Rebase against upstream main after target support added. Separate unit test for DSL. Address comments: do not save ES version in client, add apply target method in executors, set to target if target is defined, docs update. Co-authored-by: Rye Biesemeyer <yaauie@users.noreply.github.com> * Introduce query_type option which accepts dsl or esql to define a query shape. Remove multi-depth nested named_params and keep only top-level query_params which aligns with placeholder structure in the ES|QL. * Separate event referenced and static valued fields at initialization of the ESQL executor. * query_params now supports both Array and Hash types. * Add tech preview section under ESQL. * Place the query results based on the target specified. If not specified, first result will be set to event's top level. * Apply suggestions from code review Doc corrections. Co-authored-by: João Duarte <jsvd@users.noreply.github.com> * ES|QL result mapping to event doc correction. * Integration tests to run with credentials enabled and SSL configs. --------- Co-authored-by: Rye Biesemeyer <yaauie@users.noreply.github.com> Co-authored-by: João Duarte <jsvd@users.noreply.github.com> (cherry picked from commit 5e3c464)
mashhurs
force-pushed
the
esql-support-3.x
branch
from
0f4d77b to
a573d62
Compare
Contributor
Author
Solved by #200 |
jsvd
approved these changes
Jul 21, 2025
Contributor
Author
|
Published with v3.19.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of 5e3c464
ESQL and DSL executors are introduced. param can accept ES|QL query shape now. is introduced for initial step but needs team's feedback. DSL logics moved into DSL executors.
Apply suggestions from code review
Separate DSL and ESQL interface in the client.
Rebase against upstream main after target support added. Separate unit test for DSL. Address comments: do not save ES version in client, add apply target method in executors, set to target if target is defined, docs update.
Introduce query_type option which accepts dsl or esql to define a query shape. Remove multi-depth nested named_params and keep only top-level query_params which aligns with placeholder structure in the ES|QL.
Separate event referenced and static valued fields at initialization of the ESQL executor.
query_params now supports both Array and Hash types.
Add tech preview section under ESQL.
Place the query results based on the target specified. If not specified, first result will be set to event's top level.
Apply suggestions from code review
Doc corrections.
ES|QL result mapping to event doc correction.
Integration tests to run with credentials enabled and SSL configs.
(cherry picked from commit 5e3c464)
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/