Enhance error logs for invalid custom fields#235
Merged
kaisecheng merged 5 commits intologstash-plugins:mainfrom Nov 4, 2025
Merged
Enhance error logs for invalid custom fields#235kaisecheng merged 5 commits intologstash-plugins:mainfrom
kaisecheng merged 5 commits intologstash-plugins:mainfrom
Conversation
1d48c77 to
e4a5c39
Compare
alexcams
reviewed
Nov 4, 2025
| static class GeoIp2InvalidCustomFieldException extends GeoIp2Exception { | ||
| public GeoIp2InvalidCustomFieldException(Throwable cause) { | ||
| super("invalid custom field", cause); | ||
| super("The database contains invalid custom field, which caused deserialization to fail.", cause); |
alexcams
approved these changes
Nov 4, 2025
alexcams
left a comment
There was a problem hiding this comment.
LGTM! with minor to remove double tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add error logs when MaxMind databases fail to deserialize custom field
Fix: #233
How to test this PR
The instruction is copied from #226
is_in_european_union