Mark deprecated SSL settings as obsolete#54
Merged
robbavey merged 2 commits intologstash-plugins:mainfrom Dec 16, 2024
Merged
Conversation
- SSL settings that were marked deprecated in version `1.6.0` are now marked obsolete, and will prevent the plugin from starting. - These settings are: - `cacert`, which should be replaced by `ssl_certificate_authorities` - `client_cert`, which should be replaced by `ssl_certificate` - `client_key`, which should be replaced by `ssl_key` - `keystore`, which should be replaced by `ssl_keystore_path` - `keystore_password`, which should be replaced by `ssl_keystore_password` - `keystore_type`, which should be replaced by `ssl_keystore_password` - `truststore`, which should be replaced by `ssl_truststore_path>` - `truststore_password`, which should be replaced by `ssl_truststore_password` - `truststore_type`, which should be replaced by `ssl_truststore_type` - [#xxx](https://github.com/logstash-plugins/logstash-filter-http/pull/xxx)
robbavey
force-pushed
the
obsolete_ssl
branch
from
d728dea to
c9ba651
Compare
7 tasks
donoghuc
reviewed
Nov 27, 2024
donoghuc
reviewed
Nov 27, 2024
donoghuc
requested changes
Nov 27, 2024
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Just a couple suggestions for an apparent copy paste issue.
Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
Member
Author
|
Well spotted @donoghuc! |
donoghuc
approved these changes
Dec 2, 2024
Member
Author
|
Ready for docs review @karenzone |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.6.0are now marked obsolete, and will prevent the plugin from starting.cacert, which should be replaced byssl_certificate_authoritiesclient_cert, which should be replaced byssl_certificateclient_key, which should be replaced byssl_keykeystore, which should be replaced byssl_keystore_pathkeystore_password, which should be replaced byssl_keystore_passwordkeystore_type, which should be replaced byssl_keystore_passwordtruststore, which should be replaced byssl_truststore_path>truststore_password, which should be replaced byssl_truststore_passwordtruststore_type, which should be replaced byssl_truststore_typeRelates: #53