Remove unused adal4j, refresh consuming dependencies#107
Conversation
|
I'm not sure I understand... |
|
Looks like these were introduced with 6589acd We can see that they are included as runtime dependencies: https://github.com/Azure/autorest-clientruntime-for-java/blob/master/azure-client-authentication/pom.xml and https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/eventhubs/microsoft-azure-eventhubs/pom.xml While it does not look like the plugin uses any classes directly, it seems risky removing explicitly declare dependencies (IE how can we be sure those classes are not attempted to be loaded in code paths outside the plugin). |
|
We have observed a bug with packaging. Now, as long as we keep the |
…h packages) and test with Azure cloud env.
1d488c3 to
cc6070a
Compare
| require_jar('com.microsoft.azure', 'qpid-proton-j-extensions', '1.2.4') | ||
| require_jar('com.microsoft.azure', 'azure-eventhubs-eph', '3.3.0') | ||
| require_jar('com.microsoft.azure', 'azure-storage', '8.6.6') | ||
| require_jar('com.microsoft.azure', 'azure-client-authentication', '1.7.3') |
There was a problem hiding this comment.
Oh, oops I should have checked these in in my other PR. Thanks
Description
With #113 PR, I have observed that
adal4jdependency isn't loaded unless we change the source code to utilize the ADA (Active Directory Auth) feature.That indicates we don't need to include ada;4j in the package, which LS artifact will not be also carrying.
This PR
adal4jdependency group to avoid consuming it and its transitive dependenciesjar-dependencylist in thelogstash-input-azure_event_hubs.rbfileTesting
Test logs: