Merged
Conversation
mashhurs
commented
Jan 28, 2026
| w << "require_jar(\'${id.group}\', \'${id.module}\', \'${id.version}\')\n" | ||
| } | ||
| } | ||
| w << "\nrequire_jar(\'${project.group}\', \'${project.name}\', \'${project.version}\')\n" |
Contributor
Author
There was a problem hiding this comment.
This changes do not change any behavior but interestingly, project JAR isn't used anywhere (I was expecting require "logstash-input-file_jars"), some files seems (watched_files_collection.rb -> WatchedFilesCollection?) referencing.
There was a problem hiding this comment.
Interesting. I think given the only dep is an old jruby version i'm guessing there just are not really any deps needed. I think for consistency across projects its fine to just do this update anyway.
donoghuc
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs: