Mark previously deprecated SSL settings as obsolete#149
Merged
robbavey merged 3 commits intologstash-plugins:mainfrom Dec 16, 2024
Merged
Mark previously deprecated SSL settings as obsolete#149robbavey merged 3 commits intologstash-plugins:mainfrom
robbavey merged 3 commits intologstash-plugins:mainfrom
Conversation
- SSL settings that were marked deprecated in version `5.6.0` are now marked obsolete, and will prevent the plugin from starting. - These settings are: - `cacert`, which should be replaced by `ssl_certificate_authorities` - `client_cert`, which should be replaced by `ssl_certificate` - `client_key`, which should be replaced by `ssl_key` - `keystore`, which should be replaced by `ssl_keystore_path` - `keystore_password`, which should be replaced by `ssl_keystore_password` - `keystore_type`, which should be replaced by `ssl_keystore_password` - `truststore`, which should be replaced by `ssl_truststore_path>` - `truststore_password`, which should be replaced by `ssl_truststore_password` - `truststore_type`, which should be replaced by `ssl_truststore_type`
7 tasks
donoghuc
reviewed
Dec 9, 2024
spec/inputs/http_poller_spec.rb
Outdated
| before do | ||
| Timecop.travel(Time.new(2000,1,1,0,0,0,'+00:00')) | ||
| Timecop.scale (60 * 5) / 2 | ||
| Timecop.scale (60) |
Contributor
There was a problem hiding this comment.
Sorry if I missed it, but what are the adjustments to the schedule tests? Is t to reduce test time/resource utilization? A race condition?
Member
Author
There was a problem hiding this comment.
I've reworked this slightly to be less of a change, and will include the following comment in the squashed merge:
This commit also fixes a failing test, where an aggressive Timecop configuration
meant that the setup for the plugin was not complete by the time the expected
scheduled job was to be run
donoghuc
approved these changes
Dec 9, 2024
Contributor
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Looks right. One question on the changes to the schedule tests, but that is not a blocker.
This commit also fixes a failing test, where an aggressive Timecop configuration meant that the setup for the plugin was not complete by the time the expected scheduled job was to be run
donoghuc
reviewed
Dec 9, 2024
donoghuc
approved these changes
Dec 9, 2024
Contributor
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Thanks for the updated commit with description! I did notice one other small thing https://github.com/logstash-plugins/logstash-input-http_poller/pull/149/files#r1876840774 Other than that this looks good.
Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
Member
Author
|
Over to you for docs review @karenzone |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5.6.0are now marked obsolete, and will prevent the plugin from starting.cacert, which should be replaced byssl_certificate_authoritiesclient_cert, which should be replaced byssl_certificateclient_key, which should be replaced byssl_keykeystore, which should be replaced byssl_keystore_pathkeystore_password, which should be replaced byssl_keystore_passwordkeystore_type, which should be replaced byssl_keystore_passwordtruststore, which should be replaced byssl_truststore_path>truststore_password, which should be replaced byssl_truststore_passwordtruststore_type, which should be replaced byssl_truststore_typeThanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/