Conversation
This commit marks the following SSL settings as obsolete: `ssl_cert`, which should be replaced by `ssl_certificate` `ssl_enable`, which should be replaced by `ssl_enabled` `ssl_verify`, which should be replaced by `ssl_client_authentication` when `mode` is `server` or `ssl_verification_mode`when mode is `client`
7 tasks
donoghuc
reviewed
Dec 9, 2024
donoghuc
reviewed
Dec 9, 2024
donoghuc
requested changes
Dec 9, 2024
Contributor
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Just a couple small docs comments. Code removal looks clean.
Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc
reviewed
Dec 9, 2024
donoghuc
approved these changes
Dec 10, 2024
Contributor
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Assuming CI is green i think this is good! Apologies for not catching everything on the first take 😬
Member
Author
All good! Thanks for being thorough and catching all of my 🤦 ... |
Member
Author
|
Ready for doc review @karenzone |
karenzone
reviewed
Dec 23, 2024
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Updated text to align with messaging for other plugins
15 tasks
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Member
Author
|
Ready for another round @karenzone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit marks the following SSL settings as obsolete:
ssl_cert, which should be replaced byssl_certificatessl_enable, which should be replaced byssl_enabledssl_verify, which should be replaced byssl_client_authenticationwhenmodeisserverorssl_verification_modewhen mode isclientRelates: #225