Add fine tuned oath/sasl configuration to kafka client#189
Merged
donoghuc merged 9 commits intologstash-plugins:mainfrom Jan 7, 2025
Merged
Add fine tuned oath/sasl configuration to kafka client#189donoghuc merged 9 commits intologstash-plugins:mainfrom
donoghuc merged 9 commits intologstash-plugins:mainfrom
Conversation
Add changelog entry and increment minor version for new configuration features.
This was referenced Jan 6, 2025
robbavey
reviewed
Jan 6, 2025
mashhurs
reviewed
Jan 6, 2025
This commit updates the plugin defaults to align with the default (or lack of default) values in the underlying kafka client library. https://github.com/apache/kafka/blob/3.8.1/clients/src/main/java/org/apache/kafka/common/TopicIdPartition.java
mashhurs
reviewed
Jan 7, 2025
Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
mashhurs
approved these changes
Jan 7, 2025
Contributor
mashhurs
left a comment
mashhurs
left a comment
There was a problem hiding this comment.
LGTM!
Thank you so much Cas.
The last failed CI seems to me transient.
Contributor
Author
|
Reload yeilded a green run. Going to merge and release. |
karenzone
reviewed
Jan 22, 2025
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Left suggestion inline to use order options alphabetically.
Comment on lines
+134
to
+140
| | <<plugins-{type}s-{plugin}-sasl_oauthbearer_token_endpoint_url>> |<<string,string>>|No | ||
| | <<plugins-{type}s-{plugin}-sasl_oauthbearer_scope_claim_name>> |<<string,string>>|No | ||
| | <<plugins-{type}s-{plugin}-sasl_login_callback_handler_class>> |<<string,string>>|No | ||
| | <<plugins-{type}s-{plugin}-sasl_login_connect_timeout_ms>> |<<number,number>>|No | ||
| | <<plugins-{type}s-{plugin}-sasl_login_read_timeout_ms>> |<<number,number>>|No | ||
| | <<plugins-{type}s-{plugin}-sasl_login_retry_backoff_ms>> |<<number,number>>|No | ||
| | <<plugins-{type}s-{plugin}-sasl_login_retry_backoff_max_ms>> |<<number,number>>|No |
Contributor
There was a problem hiding this comment.
The one got by me.
For next time: Options should be in alpha order in both option list and descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add plugin configuration options for both input/output to support oauth and sasl authentication.
This PR aggregates #183 and #181 and adds some unit tests.
I found it difficult to spin up a valid test environment to fully test the integrations, but looking at the options in https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java I think the added unit tests show that we are piping through the requested configuration to the kafka clients.
Closes #180