Add reconnect_backoff_max_ms option for configuring kafka client#204
Merged
kaisecheng merged 2 commits intologstash-plugins:mainfrom Oct 3, 2025
Merged
Conversation
The test was failing intermittently because failcount could be 0, causing the first producer#send call to skip. The random value does not test different behaviors, hence, changed to fix number.
kaisecheng
commented
Oct 2, 2025
|
|
||
| context "when KafkaProducer#send() raises a non-retriable exception" do | ||
| let(:failcount) { (rand * 10).to_i } | ||
| let(:failcount) { 3 } |
Contributor
Author
There was a problem hiding this comment.
The test was failing intermittently because failcount could be 0,
causing the first producer#send call to skip.
The random value does not test different behaviors, hence, changed to fix number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
reconnect_backoff_max_msoption for configuring kafka client.The default value is
1000, the same as the Kafka defaultFixes: #194
Tested Logstash with this kafka and no warning about "Disabling exponential reconnect backoff because reconnect.backoff.ms is set, but reconnect.backoff.max.ms is not"