Remove duplicated deprecation log entry#1232
Merged
alexcams merged 2 commits intologstash-plugins:mainfrom Oct 29, 2025
Merged
Conversation
jsvd
reviewed
Oct 27, 2025
Member
jsvd
left a comment
jsvd
left a comment
There was a problem hiding this comment.
let's bump the patch version in the gemspec and CHANGELOG so this can be released and included in the next release of Logstash
alexcams
force-pushed
the
18314-remove-deprecation-logger-duplicated-entries
branch
2 times, most recently
from
cc22a60 to
62112b9
Compare
…gger-duplicated-entries
alexcams
force-pushed
the
18314-remove-deprecation-logger-duplicated-entries
branch
from
62112b9 to
12c0ddd
Compare
Contributor
Author
@jsvd Done! |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last change on logstash core logger config wires deprecation logger to plain logger by default. It is not needed to duplicate deprecation logs anymore because any call to
deprecation_logger.deprecated()will log in plain logger output as well unless user changes this default configuration.Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/