Mark deprecated SSL settings as obsolete#147
Merged
robbavey merged 4 commits intologstash-plugins:mainfrom Nov 21, 2024
Merged
Conversation
This commit marks the following SSL settings as obsolete: 'cacert', 'client_cert', 'client_key', 'keystore', 'truststore', 'keystore_password', 'truststore_password', 'keystore_type' and 'truststore_type'.
Add documentation to state that SSL settings are obsolete
|
Could probably use a |
robbavey
force-pushed
the
obsolete_ssl
branch
from
c51cf2b to
b51e1f9
Compare
karenzone
approved these changes
Nov 20, 2024
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Left some comments inline for consideration, and otherwise, LGTM.
I tested this locally, and it builds cleanly and renders as expected.
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
6 tasks
donoghuc
added a commit
to donoghuc/logstash-input-elasticsearch
that referenced
this pull request
Dec 2, 2024
This commit updates the documentation to follow the pattern established in logstash-plugins/logstash-output-http#147 for documenting obsolete options.
donoghuc
added a commit
to donoghuc/logstash-input-elasticsearch
that referenced
this pull request
Dec 3, 2024
This commit updates the documentation to follow the pattern established in logstash-plugins/logstash-output-http#147 for documenting obsolete options.
donoghuc
added a commit
to donoghuc/logstash-input-elasticsearch
that referenced
this pull request
Dec 10, 2024
This commit updates the documentation to follow the pattern established in logstash-plugins/logstash-output-http#147 for documenting obsolete options.
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit marks the following SSL settings as obsolete:
'cacert', 'client_cert', 'client_key', 'keystore', 'truststore',
'keystore_password', 'truststore_password', 'keystore_type' and
'truststore_type'.