Skip to content

Conversation

@Light2Dark
Copy link
Contributor

📝 Summary

For column header charts for string/categories, previously even with a filter, it would still calculate value_counts based on all the rows. Leading to the chart not changing.

This fixes ensures the frontend chart changes according to filters.

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.
@vercel
Copy link

vercel bot commented Nov 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Nov 2, 2025 2:57pm
@mscolnick mscolnick merged commit 79c1394 into main Nov 2, 2025
31 of 41 checks passed
@mscolnick mscolnick deleted the sham/value_counts_bug branch November 2, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants