Skip to content

fix: remove NaN from number plugin #7364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mscolnick merged 2 commits into from
Dec 3, 2025
Merged

fix: remove NaN from number plugin #7364

mscolnick merged 2 commits into from
Dec 3, 2025

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Dec 1, 2025 •
edited
Loading

Fixes #7352, although I think the underlying issue/fix is #7363

I plan to follow up with more tests/updates to other places where this could crop up.
@vercel
Copy link

vercel bot commented Dec 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Dec 1, 2025 7:38pm
@Light2Dark Light2Dark added the bug Something isn't working label Dec 1, 2025
@Light2Dark
Copy link
Contributor

Light2Dark commented Dec 2, 2025 •
edited
Loading

Any thoughts on just doing #7363 fix & keep the tests + value ?? NaN? I think it's okay to have it as NaN
@mscolnick
Copy link
Contributor Author

mscolnick commented Dec 2, 2025

@Light2Dark - the plugin state should be serializable, and NaN will just get serialized to null. i think its ok to do that here as well (being defensive twice, since this could come up again)
@mscolnick mscolnick merged commit 7a4da52 into main Dec 3, 2025
30 of 33 checks passed
@mscolnick mscolnick deleted the ms/remove-nan-fromnumberplugin branch December 3, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants

@mscolnick @Light2Dark