improvement: make the install/uninstall API endpoints non-blocking #7375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
manzt
approved these changes
Dec 3, 2025
Contributor
manzt
left a comment
manzt
left a comment
There was a problem hiding this comment.
This seems like a reasonable/minimal change to me. It would make sense to make the package manager async itself, but I'd rather evaluate that if this doesn't sufficiently handle our current problem. We mostly want to offload the blocking nature of the install/uninstall endpoints.
Contributor
Author
|
@manzt agreed. we would just need to convert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These endpoints get block other endpoints during installation. This is now fixed by wrapping the blocking commands in a
asyncio.to_thread.Another option is to change
runto a natural async function, but that requires changing more downstream sync functions in the kernel.