Skip to content

fix: sandbox package listing#8104

Merged
dmadisetti merged 5 commits intomainfrom
dm/package-listing
Feb 4, 2026
Merged

fix: sandbox package listing#8104
dmadisetti merged 5 commits intomainfrom
dm/package-listing

Conversation

@dmadisetti
Copy link
Collaborator

@dmadisetti dmadisetti commented Feb 3, 2026 •
edited
Loading

📝 Summary

Closes #7922
supercedes #8094 (refer to this branch for a kernel level implementation)

On IPC start, note the used python in the kernel manager such that UV commands can directly utilized the correct venv.

This allows correct package listing from the packages sidebar
@vercel
Copy link

vercel bot commented Feb 3, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Feb 4, 2026 9:04pm

Request Review
@dmadisetti dmadisetti changed the title Dm/package listing Feb 3, 2026
@dmadisetti dmadisetti added the bug Something isn't working label Feb 3, 2026
dmadisetti
dmadisetti commented Feb 3, 2026
View reviewed changes
mscolnick
mscolnick reviewed Feb 3, 2026
View reviewed changes
marimo/_runtime/packages/pypi_package_manager.py Outdated
"pip",
"--python",
PY_EXE,
self._python_exe or PY_EXE,
Copy link
Contributor

@mscolnick mscolnick Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead self._python_exe gets initialized like:

self._python_exe  = python_exe or PY_EXE

then we don't need to do or PY_EXE everywhere else
@dmadisetti dmadisetti marked this pull request as ready for review February 4, 2026 00:24
@dmadisetti dmadisetti requested a review from mscolnick February 4, 2026 00:24
mscolnick
mscolnick previously approved these changes Feb 4, 2026
View reviewed changes
marimo/_server/api/endpoints/packages.py
from marimo._session.managers.ipc import IPCKernelManagerImpl
from marimo._session.session import SessionImpl

if isinstance(session, SessionImpl):
Copy link
Contributor

@mscolnick mscolnick Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be a good utility to test and reuse is_ipc_session
Copy link
Collaborator Author

@dmadisetti dmadisetti Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to unpack for KernelManager, agreed if this pattern comes up again
@mscolnick
Copy link
Contributor

mscolnick commented Feb 4, 2026

I assume add/remove from the sidebar also requires these updates?
@dmadisetti
Copy link
Collaborator Author

dmadisetti commented Feb 4, 2026

I assume add/remove from the sidebar also requires these updates?

I thought it would address this, but verified it wasn't the full solution.
The new commit does fix this.
@dmadisetti dmadisetti merged commit 3819f89 into main Feb 4, 2026
46 of 54 checks passed
@dmadisetti dmadisetti deleted the dm/package-listing branch February 4, 2026 21:53
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.8-dev26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants

@dmadisetti @mscolnick @Light2Dark