Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmadisetti
approved these changes
Feb 3, 2026
Collaborator
dmadisetti
left a comment
dmadisetti
left a comment
There was a problem hiding this comment.
Was this from an issue that we should close out?
Contributor
Author
@dmadisetti its from the flakey windows tests, not an issue |
mscolnick
deleted the
ms/fix-gracefully-handle-timeoutsinput-from-uv-when-adding-script-metadata
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the
_ensure_marimo_in_script_metadatafunction inmarimo/_cli/sandbox.pyby preventing potential hangs and handling timeouts when running subprocesses.Reliability improvements for subprocess execution:
stdin=subprocess.DEVNULLto prevent hanging on Windows whenuvmight wait for input.timeout=30for the subprocess call and added handling forTimeoutExpiredexceptions to log a warning if the operation times out.