Skip to content

don't allow '.' when creating custom provider names#8115

Merged
Light2Dark merged 1 commit intomainfrom
sham/dots-in-provider-names
Feb 4, 2026
Merged

don't allow '.' when creating custom provider names#8115
Light2Dark merged 1 commit intomainfrom
sham/dots-in-provider-names

Conversation

@Light2Dark
Copy link
Collaborator

@Light2Dark Light2Dark commented Feb 4, 2026

Provider names with . breaks saving to our toml, currently we save it as [marimo.ai.provider_name]. This adds a validation on the frontend to avoid saving a provider like this.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.
@Light2Dark Light2Dark requested a review from manzt as a code owner February 4, 2026 05:23
@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Feb 4, 2026 5:23am

Request Review

@Light2Dark Light2Dark added the bug Something isn't working label Feb 4, 2026
@Light2Dark Light2Dark changed the title don't allow . in provider names Feb 4, 2026
@Light2Dark Light2Dark changed the title don't allow '. when creating custom provider names Feb 4, 2026
@Light2Dark Light2Dark merged commit 1234c1b into main Feb 4, 2026
42 of 44 checks passed
@Light2Dark Light2Dark deleted the sham/dots-in-provider-names branch February 4, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

2 participants