fix: failed package installation commands should not kill kernel#8158
Merged
fix: failed package installation commands should not kill kernel#8158
Conversation
The runtime installs packages by issuing commands using subprocess.Popen, which can raise exceptions. Previously thrown exceptions killed the kernel. This change adds a `safe_popen` wrapper function that never throws. The implementation is verbose because we carry over typing and overloads from typeshed.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
previously approved these changes
Feb 6, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.9-dev10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime installs packages by issuing commands using
subprocess.Popen, which can raise exceptions. Previouslythrown exceptions killed the kernel.
This change adds a
safe_popenwrapper function that never throws.The implementation is verbose because we carry over typing and overloads
from typeshed.