fix: handle null registration.active in service worker registration#8213
Merged
mscolnick merged 2 commits intomarimo-team:mainfrom Feb 9, 2026
Merged
Conversation
Service worker registration code assumes `registration.active` is immediately available after calling `navigator.serviceWorker.register()`. However, service workers go through lifecycle states (installing -> waiting -> active), and `registration.active` can be `null` during transitions, causing `TypeError: registration.active is null` errors in the browser console. This adds a `sendNotebookId` helper that: - Checks if `registration.active` exists before posting the message - Falls back to listening for `statechange` on the installing/waiting worker and posts the message once activated Fixes marimo-team#5304
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
approved these changes
Feb 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mscolnick
approved these changes
Feb 9, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.10-dev20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guards against
registration.activebeing null when registering the service worker, preventing a TypeError in browsers where the service worker hasn't activated yet.Closes #8185
Test Plan