perf: don't read the full file for OSFileSystem._is_marimo_file#8253
Merged
perf: don't read the full file for OSFileSystem._is_marimo_file#8253
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates marimo app-file detection to avoid reading entire files when determining whether a path is a marimo app, and adds tests to cover Python + Markdown detection paths.
Changes:
- Delegate
OSFileSystem._is_marimo_file()to the shareddirectory_scanner.is_marimo_app()helper. - Add test coverage for
_is_marimo_file()behavior across.py,.md, other extensions, and missing files. - Minor refactors: avoid repeated
.lower()calls insearch(), and avoid repeatedapp.to_py()calls during HTML export.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/_server/files/test_os_file_system.py |
Adds tests for _is_marimo_file() and verifies list_files() marks Markdown marimo notebooks. |
marimo/_server/files/os_file_system.py |
Switches marimo file detection to use is_marimo_app(); minor search() micro-optimization. |
marimo/_server/export/exporter.py |
Computes app.to_py() once and reuses the result for code and hashing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
manzt
approved these changes
Feb 10, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.10-dev41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-use the
is_marimo_fileutil from directory scanner which is a bit better / more correct.