Skip to content

stop hardcoding us-central1 as vertex ai default location#8313

Merged
dmadisetti merged 2 commits intomarimo-team:mainfrom
Mr-Neutr0n:fix/vertex-ai-location-default
Feb 17, 2026
Merged

stop hardcoding us-central1 as vertex ai default location#8313
dmadisetti merged 2 commits intomarimo-team:mainfrom
Mr-Neutr0n:fix/vertex-ai-location-default

Conversation

@Mr-Neutr0n
Copy link
Contributor

@Mr-Neutr0n Mr-Neutr0n commented Feb 13, 2026

When using Vertex AI without setting GOOGLE_CLOUD_LOCATION, marimo hardcodes us-central1 as the fallback. This silently routes requests to a region that may be blocked by organization policies (like region restriction constraints), giving users a cryptic error with no indication of what went wrong.

This removes the hardcoded default and lets pydantic-ai handle the fallback itself. Also adds a warning log when the env var isn't set, so users in restricted environments actually know they need to configure it.

Fixes #7899
@Mr-Neutr0n
stop hardcoding us-central1 as vertex ai default location
d2785e4 
remove the hardcoded fallback to us-central1 for GOOGLE_CLOUD_LOCATION
and let pydantic-ai handle its own default. log a warning when the env
var isn't set so users in restricted regions know what's going on
instead of getting a cryptic permission error.

fixes marimo-team#7899
@vercel
Copy link

vercel bot commented Feb 13, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Feb 14, 2026 5:12am

Request Review
@Mr-Neutr0n Mr-Neutr0n mentioned this pull request Feb 13, 2026
Closed
1 task
@github-actions
Copy link

github-actions bot commented Feb 13, 2026 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.
dmadisetti
dmadisetti reviewed Feb 14, 2026
View reviewed changes
Copy link
Collaborator

@dmadisetti dmadisetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment! Might also be better as an info over a warning
@dmadisetti dmadisetti added the bug Something isn't working label Feb 14, 2026
@Light2Dark
Copy link
Collaborator

Light2Dark commented Feb 14, 2026

@Mr-Neutr0n , thanks! Could you sign the CLA so we can merge this?

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.
@Mr-Neutr0n
Copy link
Contributor Author

Mr-Neutr0n commented Feb 14, 2026

I have read the CLA Document and I hereby sign the CLA
@dmadisetti dmadisetti merged commit 45846ed into marimo-team:main Feb 17, 2026
35 of 40 checks passed
LiquidGunay pushed a commit to LiquidGunay/marimo that referenced this pull request Feb 21, 2026
@Mr-Neutr0n @LiquidGunay
stop hardcoding us-central1 as vertex ai default location (marimo-tea…
9e4af10 
…m#8313)

When using Vertex AI without setting `GOOGLE_CLOUD_LOCATION`, marimo
hardcodes `us-central1` as the fallback. This silently routes requests
to a region that may be blocked by organization policies (like region
restriction constraints), giving users a cryptic error with no
indication of what went wrong.

This removes the hardcoded default and lets pydantic-ai handle the
fallback itself. Also adds a warning log when the env var isn't set, so
users in restricted environments actually know they need to configure
it.

Fixes marimo-team#7899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants

@Mr-Neutr0n @Light2Dark @dmadisetti