Skip to content

display mermaid error if present and strip diagram#8368

Merged
akshayka merged 1 commit intomainfrom
sham/mermaid-error-whitespace-fix
Feb 19, 2026
Merged

display mermaid error if present and strip diagram#8368
akshayka merged 1 commit intomainfrom
sham/mermaid-error-whitespace-fix

Conversation

@Light2Dark
Copy link
Collaborator

📝 Summary

Fixes #8367

If error:

image

strip diagram:

image

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.
@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Feb 19, 2026 10:04am

Request Review

"SECURITY.md", # Contains usernames that trigger typos
"patches/*", # Patches may contain typos from source code
"patches/*", # Patches may contain typos from source code,
"frontend/dist/assets/*", # Assets may contain typos from source code
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by fix for pre-commit

@Light2Dark Light2Dark added the bug Something isn't working label Feb 19, 2026
@akshayka akshayka merged commit ba33e07 into main Feb 19, 2026
41 of 50 checks passed
@akshayka akshayka deleted the sham/mermaid-error-whitespace-fix branch February 19, 2026 15:23
LiquidGunay pushed a commit to LiquidGunay/marimo that referenced this pull request Feb 21, 2026
## 📝 Summary

<!--
Provide a concise summary of what this pull request is addressing.

If this PR closes any issues, list them here by number (e.g., Closes
marimo-team#123).
-->
Fixes marimo-team#8367

If error:

<img width="595" height="244" alt="image"
src="https://github.com/user-attachments/assets/be82d3b5-d60d-4478-ad80-c52e95b88f91"
/>

strip diagram:

<img width="618" height="289" alt="image"
src="https://github.com/user-attachments/assets/8284bd61-f77e-4d01-aa55-f6e16fdca6d8"
/>

## 🔍 Description of Changes

<!--
Detail the specific changes made in this pull request. Explain the
problem addressed and how it was resolved. If applicable, provide before
and after comparisons, screenshots, or any relevant details to help
reviewers understand the changes easily.
-->

## 📋 Checklist

- [x] I have read the [contributor
guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md).
- [ ] For large changes, or changes that affect the public API: this
change was discussed or approved through an issue, on
[Discord](https://marimo.io/discord?ref=pr), or the community
[discussions](https://github.com/marimo-team/marimo/discussions) (Please
provide a link if applicable).
- [x] Tests have been added for the changes made.
- [ ] Documentation has been updated where applicable, including
docstrings for API changes.
- [x] Pull request title is a good summary of the changes - it will be
used in the [release
notes](https://github.com/marimo-team/marimo/releases).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

2 participants