wasm: check platform instead of sys.modules for pyodide check#9404
Merged
mscolnick merged 3 commits intoApr 27, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Marimo’s runtime platform detection to identify Pyodide/WASM by checking the interpreter’s platform string rather than relying on whether the pyodide module has been imported.
Changes:
- Update
is_pyodide()to usesys.platform == "emscripten"instead of"pyodide" in sys.modules.
![cubic-dev-ai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The @patch.dict(sys.modules, ...) approach no longer triggers is_pyodide() now that it checks sys.platform == "emscripten".
mscolnick
deleted the
ms/wasm-check-platform-instead-of-sysmodules-for-pyodide-check
branch
Contributor
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.4-dev14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to use
sys.platform = "emscripten"than potentially corruptedsys.modules